pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
73 stars 22 forks source link

Adds Annealed Importance Sampling #550

Open BradyPlanden opened 2 weeks ago

BradyPlanden commented 2 weeks ago

Description

Adds an annealed importance sampling class for marginal likelihood computation.

Issue reference

Fixes #549

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

Thank you for contributing to our project! Your efforts help us to deliver great software.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 71.83099% with 20 lines in your changes missing coverage. Please review.

Project coverage is 98.68%. Comparing base (c8b00e6) to head (c5eef05). Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/parameters/priors.py 9.09% 10 Missing :warning:
pybop/samplers/annealed_importance.py 83.05% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #550 +/- ## =========================================== - Coverage 99.08% 98.68% -0.41% =========================================== Files 52 56 +4 Lines 3605 3941 +336 =========================================== + Hits 3572 3889 +317 - Misses 33 52 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.