pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
74 stars 23 forks source link

Add ECM example with change of parameters #557

Closed NicolaCourtier closed 1 week ago

NicolaCourtier commented 1 week ago

Description

Add an example showing how to optimise over a change of parameters, e.g. (R, tau) pairs instead of (R, C) pairs.

Issue reference

Fixes #396 (point 2).

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

Thank you for contributing to our project! Your efforts help us to deliver great software.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.14%. Comparing base (c8b00e6) to head (409de77). Report is 16 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #557 +/- ## =========================================== + Coverage 99.08% 99.14% +0.05% =========================================== Files 52 55 +3 Lines 3605 3848 +243 =========================================== + Hits 3572 3815 +243 Misses 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: