pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
73 stars 22 forks source link

Scheduled tests, lychee, default bounds #562

Closed BradyPlanden closed 3 days ago

BradyPlanden commented 3 days ago

Description

This PR does the following:

Issue reference

Fixes #556

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

Thank you for contributing to our project! Your efforts help us to deliver great software.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.14%. Comparing base (c8b00e6) to head (539d5c0). Report is 18 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #562 +/- ## =========================================== + Coverage 99.08% 99.14% +0.05% =========================================== Files 52 55 +3 Lines 3605 3848 +243 =========================================== + Hits 3572 3815 +243 Misses 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

BradyPlanden commented 3 days ago

Scheduled tests are still failing, see most recent run: https://github.com/pybop-team/PyBOP/actions/runs/11938283633; however, this is not due to the rhat assertion. We will need to take a look at the AdamW setup for the next round of integration test improvement steps.