Closed BradyPlanden closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.14%. Comparing base (
c8b00e6
) to head (539d5c0
). Report is 18 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Scheduled tests are still failing, see most recent run: https://github.com/pybop-team/PyBOP/actions/runs/11938283633; however, this is not due to the rhat assertion. We will need to take a look at the AdamW setup for the next round of integration test improvement steps.
Description
This PR does the following:
Issue reference
Fixes #556
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.