search

pybricks / pybricks-api

User API and documentation for Pybricks MicroPython
https://pypi.org/project/pybricks
MIT License
81 stars 23 forks source link

Fix wrong typing in pybricks.parameters.Stop #109

Closed TheVinhLuong102 closed 2 years ago

TheVinhLuong102 commented 2 years ago

David, Laurens,

I've found some minor wrong typing info.

dlech commented 2 years ago

Thanks! Can you also add a changelog entry for this?

TheVinhLuong102 commented 2 years ago

Yes, David, I've added a line about this in the change log. :)

dlech commented 2 years ago

I just pushed a commit to master that should fix the CI failures. Can you please rebase both pull requests so we can try the CI again?

TheVinhLuong102 commented 2 years ago

great, it seems all sorted out now David :)

dlech commented 2 years ago

Merged, thanks!

TheVinhLuong102 commented 2 years ago

Labor Day achievement! :D

Thanks David.