pyca / cryptography

cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.
https://cryptography.io
Other
6.71k stars 1.54k forks source link

Mac install fails with fatal error: 'openssl/opensslv.h' file not found (tried previous instructions) #3489

Closed kevinburke closed 7 years ago

kevinburke commented 7 years ago

When I run pip install cryptography I get the following error:

... lots of output ...
    running build_ext
    generating cffi module 'build/temp.macosx-10.12-x86_64-2.7/_commoncrypto.c'
    creating build/temp.macosx-10.12-x86_64-2.7
    generating cffi module 'build/temp.macosx-10.12-x86_64-2.7/_padding.c'
    generating cffi module 'build/temp.macosx-10.12-x86_64-2.7/_constant_time.c'
    generating cffi module 'build/temp.macosx-10.12-x86_64-2.7/_openssl.c'
    building '_openssl' extension
    creating build/temp.macosx-10.12-x86_64-2.7/build
    creating build/temp.macosx-10.12-x86_64-2.7/build/temp.macosx-10.12-x86_64-2.7
    cc -arch x86_64 -O2 -fPIC -Wimplicit -I/Users/kevin/src/github.com/jkbrzt/httpie/venv/include -c build/temp.macosx-10.12-x86_64-2.7/_openssl.c -o build/temp.macosx-10.12-x86_64-2.7/build/temp.macosx-10.12-x86_64-2.7/_openssl.o
    build/temp.macosx-10.12-x86_64-2.7/_openssl.c:433:10: fatal error: 'openssl/opensslv.h' file not found
    #include <openssl/opensslv.h>

Issue #3367 suggested upgrading pip. I am using the latest version of pip:

$ pip install -U pip
Requirement already up-to-date: pip in ./venv/site-packages
$ pip --version
pip 9.0.1 from /Users/kevin/src/github.com/jkbrzt/httpie/venv/site-packages (python 2.7)

It also fails outside of the virtualenv. I am not sure why pip is trying to build the wheel instead of using the downloadable wheel.

I tried removing ~/Library/Caches/pip and reinstalling and I am getting the same error.

I use Homebrew but brew link openssl --force fails now with this error message:

$ brew link openssl
Warning: Refusing to link: openssl
Linking keg-only openssl means you may end up linking against the insecure,
deprecated system OpenSSL while using the headers from Homebrew's openssl.
Instead, pass the full include/library paths to your compiler e.g.:
  -I/usr/local/opt/openssl/include -L/usr/local/opt/openssl/lib

I tried running LDFLAGS="-I/usr/local/opt/openssl/include -L/usr/local/opt/openssl/lib" pip install cryptography and got the same error as above. I also tried pip install cryptography --global-option="-L/usr/local/opt/openssl/lib" and got a different, but not more promising, error.

Here is the Python version both inside and outside of the virtual environment:

$ python
Python 2.7.12 (aff251e54385, Nov 09 2016, 17:25:49)
[PyPy 5.6.0 with GCC 4.2.1 Compatible Apple LLVM 5.1 (clang-503.0.40)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

Here is the system openssl:

$ openssl version
OpenSSL 0.9.8zh 14 Jan 2016

Here is the Homebrew openssl version (not sure how to link this or specify it when running pip install)

$ /usr/local/Cellar/openssl/1.0.2k/bin/openssl version
OpenSSL 1.0.2k  26 Jan 2017

I am running macOS Sierra version 10.12.4. Happy to provide any more debugging information as necessary; I'm not sure what more you would look for.

kevinburke commented 7 years ago

Huh, this incantation worked (I left off the --global-option=build_ext before):

pip install cryptography --global-option=build_ext --global-option="-L/usr/local/opt/openssl/lib" --global-option="-I/usr/local/opt/openssl/include"
reaperhulk commented 7 years ago

Huh, we definitely ship wheels for that Python/macOS version (in fact most of us develop on that!). Could you give me the output of: python -c "import pprint;from pip import pep425tags;pp = pprint.PrettyPrinter(indent=4);pp.pprint(pep425tags.get_supported())" ?

kevinburke commented 7 years ago

https://gist.github.com/kevinburke/932924c58707577ad577818f32075138

reaperhulk commented 7 years ago

Ah, you're actually running on pypy? pypy's ABI stability for wheels has historically been problematic so we haven't been shipping wheels there. For example, your gist shows the ABI tag for your version would be pp256-pypy_41. This probably means it's pypy2 5.6? I have a copy of pypy2 5.4 on my machine and the wheel tag is pp254-pypy_41. So we'd need to have different wheels for every version 😢

Maybe we need to do a better job documenting what to do if you're on the latest pip and still get this error (or prominently note that pypy, while supported, does not have prebuilt wheels unfortunately)

kevinburke commented 7 years ago

Oh, right.

Ideally in the error message from pip install - is that even possible? or easily searchable - for example in the comments to #3367 which was the first Google result I landed on.

alex commented 7 years ago

Seems like an actionable item here is to improve our FAQ question answer to mention PyPy.

kevinburke commented 7 years ago

In my specific case I installed Pypy from pyenv, which is why it was failing I think - it wasn't linking against Homebrew OpenSSL.

On Sun, Apr 9, 2017 at 06:19 Paul Kehrer notifications@github.com wrote:

Closed #3489 https://github.com/pyca/cryptography/issues/3489 via e660ffe https://github.com/pyca/cryptography/commit/e660ffe2e690291649781ceb173e572767a6f0ec .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pyca/cryptography/issues/3489#event-1035467780, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOSI6uRkGLyYtgODF5Q6HwF1OowcqSGks5ruNrKgaJpZM4MzutJ .

--

-- Kevin Burke 925.271.7005 | kev.inburke.com

heralight commented 7 years ago

Ok, fixed. There was some old dependencies in Pillow which force downgrade to cryptography 1.5.1 which have this bug. Force dependency to cryptography==1.8.1 do the trick.

best regards,

Alexandre

Hi,

I have exact same problem without pypy on fresh virtualenv set with python 3.6 on mac sierra . https://gist.github.com/heralight/bdbcd2edd4248acf50c330fc59713653

https://github.com/pyca/cryptography/issues/3489#issuecomment-291749772 this comment fix this issue but this solution is not very handy... do you have an idea howto fix this problem ?

Thank guy !

rgardam commented 7 years ago

I was able to get this to work by upgrading openssl using brew

brew upgrade openssl

and then setting the CPPFLAGS and LDFLAGS to point to the openssl lib from brew

export CPPFLAGS=-I/usr/local/opt/openssl/include
export LDFLAGS=-L/usr/local/opt/openssl/lib
philipplaeubli commented 7 years ago

Thanks @rgardam! Actually just setting the CPPFLAGS and LDFLAGS was enough in my environment.

reaperhulk commented 7 years ago

Since this issue keeps coming up I'm going to lock this conversation, but for reference:

Generally you should always update pip first since in many cases the reason someone doesn't get a wheel (for any platform!) is that wheel tags have shifted over time and the version of pip in use doesn't know what newer tags mean.

Also note that the version you're attempting to install may not have wheels (especially for arm64 macOS!). Always install the latest version if you can.