pyca / pynacl

Python binding to the Networking and Cryptography (NaCl) library
https://pynacl.readthedocs.io/
Apache License 2.0
1.06k stars 233 forks source link

Annotations in `tests`, part 1 #725

Closed DMRobertson closed 2 years ago

DMRobertson commented 2 years ago

Draft for now while CI runs.

I started by adding annotations to tests.utils like I did the rest of the project, using the same strict config as before. Then I took a few modules and ran mypy on them, and dealt with any unexpected complaints reported by mypy. Then I suppressed the uninteresting errors in mypy config.

Its complaints so far:

I didn't feel like annotating check_type_error three times, so I pulled it out to tests.utils. It's a bit naughty to do so in this PR (could spin it out?) and I felt a bit icky making utils pull in pytest.

reaperhulk commented 2 years ago

Huge thanks for working through this big project with me. I think this is the last thing I would consider a blocker for the next pynacl release, so now it's just some housekeeping and getting a release out the door in the next few days/weeks.

DMRobertson commented 2 years ago

Huge thanks for working through this big project with me.

My pleasure---thanks for reviewing!