pycaret / pycaret

An open-source, low-code machine learning library in Python
https://www.pycaret.org
MIT License
8.93k stars 1.77k forks source link

Time Series MLFlow logging during `setup` #1790

Closed ngupta23 closed 2 years ago

ngupta23 commented 3 years ago

Additionally, all the plots that doesn't require estimator can also be lagged at a setup stage such as ACF, PACF, ts, etc.

This is a good feature to have. We will take this up later (after model MLFlow logging is implemented).

Originally posted by @ngupta23 in https://github.com/pycaret/pycaret/issues/1782#issuecomment-955689962

github-actions[bot] commented 2 years ago

Stale issue message: This issue will be automatically closed by GitHub Actions in 1 week if there is no further activity.

github-actions[bot] commented 2 years ago

Stale issue message: This issue will be automatically closed by GitHub Actions in 1 week if there is no further activity.

ngupta23 commented 2 years ago

We want to log the following plots during setup

ngupta23 commented 2 years ago

This can mimic the way _mlflow_log_model is implemented

https://github.com/pycaret/pycaret/blob/b3fcf143f8d0dfae008fe8b69aef82074bec8215/pycaret/internal/pycaret_experiment/tabular_experiment.py#L168

So, maybe create another method called _mlflow_log_setup (called at the end of setup) and internally, you can call the respective plot_model calls (similar to what is done inside _mlflow_log_model

https://github.com/pycaret/pycaret/blob/b3fcf143f8d0dfae008fe8b69aef82074bec8215/pycaret/internal/pycaret_experiment/tabular_experiment.py#L293

ryanxjhan commented 2 years ago

Hi @ngupta23, can you assign this issue to me? Thanks!

ryankarlos commented 2 years ago

@ngupta23 Is this issue being worked on or can I have a go ? My first contribution to pycaret

ngupta23 commented 2 years ago

Thanks @ryankarlos. I have assigned it to you. This is not being worked on right now by anyone.