search

pycasbin / postgresql-watcher

PostgreSQL Watcher for PyCasbin
https://github.com/casbin/pycasbin
Apache License 2.0
1 stars 8 forks source link

initial commit #1

Closed LiuG-lynx closed 3 years ago

LiuG-lynx commented 3 years ago

I've added the code and tested it, and I'm not sure what else I need to do for my PR

Fix: https://github.com/pycasbin/postgresql-watcher/issues/2

hsluoyz commented 3 years ago

@techoner please review.

hsluoyz commented 3 years ago

@LiuG-lynx is this ready for review?

LiuG-lynx commented 3 years ago

@hsluoyz Completed for this weekend

LiuG-lynx commented 3 years ago

I'm really sorry that I was working a this weekend because the project was launched. I will finish it early next week. @hsluoyz

gerbyzation commented 3 years ago

@hsluoyz little bit confused why this got merged already, no one has vetted this and @LiuG-lynx seems to be still working on this. The current code in the main branch doesn't run and has no setup.py so it's not installable as a package.

@LiuG-lynx we all have a life outside of github 😉 Looking forward to see the rest of your work. If there's anything I can do to help let me know

hsluoyz commented 3 years ago

@gerbyzation I didn't expect this PR only will work.

@LiuG-lynx look forward to your next PR!