pycasbin / postgresql-watcher

PostgreSQL Watcher for PyCasbin
https://github.com/casbin/pycasbin
Apache License 2.0
1 stars 8 forks source link

Add a Django example and setup.py #3

Closed LiuG-lynx closed 3 years ago

LiuG-lynx commented 3 years ago

I've added examples of the Django framework to this repository, check out the README to learn more.There is currently no packaged version.It can only be used as a local py file @gerbyzation

I am not sure how to package this Repository currently. I have added setup.py but it has not been tested. Where can I get help @hsluoyz

LiuG-lynx commented 3 years ago

It can be viewed in this repository before merging @gerbyzation https://github.com/LiuG-lynx/postgresql-watcher

hsluoyz commented 3 years ago

@LiuG-lynx we can review your code here in this PR. This is why we have Pull Request :) I just want to make sure the time that you make it ready for review.

LiuG-lynx commented 3 years ago

@hsluoyz Please refer to the link text to set the username and password, and trigger the github action when a new release is built. Since I am not sure how to create a fake postgresql connection, I did not verify the unit test on the github action, only verified it locally. https://docs.github.com/en/actions/reference/encrypted-secrets

hsluoyz commented 3 years ago

@gerbyzation @techoner plz review.

leeqvip commented 3 years ago

@LiuG-lynx Can you squash your commits into one?

hsluoyz commented 3 years ago

@LiuG-lynx plz resolve the conflicts and respond to reviews.

image

Zxilly commented 3 years ago

@LiuG-lynx any progress on this?

hsluoyz commented 3 years ago

@Zxilly he already quited. So no reply would be expected. Can you borrow the useful code in this PR and make a new PR instead?