Fix tests and badges like CI, code coverage, etc.

pycasbin / postgresql-watcher

PostgreSQL Watcher for PyCasbin

https://github.com/casbin/pycasbin

Apache License 2.0

1 stars 8 forks source link

Fix tests and badges like CI, code coverage, etc. #4

Closed hsluoyz closed 3 years ago

hsluoyz commented 3 years ago

@ashish493

ashish493 commented 3 years ago

Will start working on it.

ashish493 commented 3 years ago

@hsluoyz , In the line mentioned in the function of casbin_subscription, I couldn't find any type of attribute related to multiprocessing.connection.pipeconnection. I even tried seaching on official docs but couldn't find it. And if there isn't any such attribute, then rectifying it would be hard. :(

Also the postgreSQL action used in the CI only works for Linux. For mac and windows, I need to setup the postgreSQL manually for the CI.

hsluoyz commented 3 years ago

@Zxilly any comment?

Zxilly commented 3 years ago

@ashish493 plz turn to @LiuG-lynx for help. Maybe there's no need to test watcher on different platform? If you do want to test it on MacOS or Windows, you need to manually setup database.

hsluoyz commented 3 years ago

@Zxilly

I guess @LiuG-lynx is not in the community any more. We need to resolve it by ourselves.

I don't think we need to run tests all so many OSs. Only testing against Linux is OK. But we need to just make sure the final code can run on all OSs, for example, don't use a Windows-specific API to make it fail to run on Linux.

Zxilly commented 3 years ago

@hsluoyz I'm working on cross platform support.

hsluoyz commented 3 years ago

@Zxilly CI is fixed, thanks!

Coverage is still down.

Zxilly commented 3 years ago

@hsluoyz I will add it to CI.

hsluoyz commented 3 years ago

Done: