Fix bot issues - Githubissues

pyccel / pyccel-cuda

Cuda extension to pyccel

MIT License

1 stars 0 forks source link

Fix bot issues #33

Closed EmilyBourne closed 8 months ago

EmilyBourne commented 8 months ago

Fix several minor bugs with the bot. Namely:

indenting in pytest_run/action.yml which prevents tests from running
Ordering of setup in cuda workflow preventing setup action from running
Missing argument to setup.py
Missing description for cuda test
Ensure cuda tests are triggered on devel branch
Report outcome of cuda step

pyccel-bot[bot] commented 8 months ago

Hello again! Thank you for this new pull request :star_struck:.

Please begin by requesting your checklist using the command /bot checklist

EmilyBourne commented 8 months ago

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

[x] Write a clear PR description
[x] Add tests to check your code works as expected
[x] Update documentation if necessary
[x] Update Changelog
[x] Ensure any relevant issues are linked
[x] Ensure new tests are passing

pyccel-bot[bot] commented 8 months ago

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @bauom think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks :smile: