Closed smazouz42 closed 2 hours ago
Hello again! Thank you for this new pull request :star_struck:.
Please begin by requesting your checklist using the command /bot checklist
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready
.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready
.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready
.
/bot run docs
/bot run docs
/bot run docs
/bot run docs
Hey @pyccel/pyccel-dev ! @smazouz42 has just created this great new pull request! Check it out and let me know what you think!
Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @smazouz42 and @jalalium think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks :smile:
@smazouz42, @EmilyBourne has a few questions/comments about your code. Can you go through and see if you agree with them. If not go ahead and explain why. Once you've adressed all the comments let me know with /bot mark as ready
and we will see if we can get approval.
@smazouz42, @EmilyBourne has a few questions/comments about your code. Can you go through and see if you agree with them. If not go ahead and explain why. Once you've adressed all the comments let me know with /bot mark as ready
and we will see if we can get approval.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready
.
@EmilyBourne, @smazouz42 has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now?
Please fix merge conflicts so this can be merged
/bot run pr_tests
@smazouz42, @EmilyBourne has a few questions/comments about your code. Can you go through and see if you agree with them. If not go ahead and explain why. Once you've adressed all the comments let me know with /bot mark as ready
and we will see if we can get approval.
/bot run pr_tests
This pull request addresses issue #59 by adding more CUDA-specific keywords to enhance the checking of variable/function names and prevent name clashes