search

pyccel / pyccel

Python extension language using accelerators
MIT License
335 stars 55 forks source link

COVERAGE : tuples in _visit_Assign Function #1392

Open EniddeallA opened 1 year ago

EniddeallA commented 1 year ago

Untested code

The untested code is: https://github.com/pyccel/pyccel/blob/28aa4a5570ff0948ab354307b062ddc65b9a5118/pyccel/parser/semantic.py#L2573-L2609

The problem was discovered in PR : #1385

This problem needs to be investigated. Either a test should be added which uses this code, or the code should be removed.

sboof911 commented 1 year ago

After doing some tests I found that we can access the two conditions : https://github.com/pyccel/pyccel/blob/28aa4a5570ff0948ab354307b062ddc65b9a5118/pyccel/parser/semantic.py#L2573-L2583 and https://github.com/pyccel/pyccel/blob/28aa4a5570ff0948ab354307b062ddc65b9a5118/pyccel/parser/semantic.py#L2595-L2604 I should add some tests for them. But after reviewing this code https://github.com/pyccel/pyccel/blob/28aa4a5570ff0948ab354307b062ddc65b9a5118/pyccel/parser/semantic.py#L2585-L2593 the condition isinstance(d_var, list) and len(d_var)== n is never satisficed because the type of d_var is always a dictionary and their is no relation between len(d_var) and n; n is the number of the variables on the lhs; Therefore, I believe this code segment is dead code and can be safely removed.