search

pyccel / sympde

Symbolic calculus for partial differential equations (and variational forms)
http://sympde.readthedocs.io/
MIT License
20 stars 4 forks source link

Devel psydac #64

Closed saidctb closed 4 years ago

yguclu commented 4 years ago

Codacy complains about an unused import. I can take care of it.

yguclu commented 4 years ago

@saidctb Actually Codacy's complaint may have uncovered a conceptual issue.

You have added an import of VectorFunctionSpace, but it is never used. Instead, in _split_test_function(expr) you create a ScalarFunctionSpace for each component of expr. Is this because we are implicitly assuming that any VectorFunctionSpace is a tensor product of ScalarFunctionSpaces?

I think that such an assumption belongs to psydac, which uses tensor-product splines, but not to sympde, which does not know anything about the discretization.