Closed vrde closed 6 years ago
@subsetpark any suggestion on how to backport the test to Python 2.7? One idea is to use mock, I can add it to requirements.tests.txt
.
@vrde Yeah, I think it's totally kosher to add a requirement on mock. Let me know if you need any other feedback.
@vrde while you're at it, I think skip_bad_files
is not a great name. What would you think about aliasing to something like skip_failures
or continue_on_failure
or what have you?
@subsetpark thanks for your comments.
@vrde while you're at it, I think skip_bad_files is not a great name. What would you think about aliasing to something like skip_failures or continue_on_failure or what have you?
What about -x, --ignore-errors
?
For my taste, the default behavior should be to ignore errors, and have a --strict
flag (or something similar) that makes the program exit on the first error.
@subsetpark thanks for your comments. ...
@vrde I like the first suggestion... I think the second is a step too far for now.
I like the first suggestion... I think the second is a step too far for now.
Sure, check my last commit. I changed the shortcut from -x
to -e
because the full flag is called --ignore-errors (i is already taken by --index
). I can change it back to -x
if you prefer, up to you :)
All green. To be honest the CI failed on my last commit, something with hypothesis
, tell me if you think it's crucial. I committed exactly the same change again to trigger another build, and this passes now.
Thanks @vrde - but I'd rather have both command flags point to the same argument, rather than break the command-line API.
Thanks @vrde - but I'd rather have both command flags point to the same argument, rather than break the command-line API.
Sure thing. I just noticed you said "aliasing" in one of your comments.
@vrde , thanks for your work! I’ve got a minor refactor to merge after this one then I’ll cut a new version.
I had some problems running
pycco
in a directory containing some cached Pytest files (.pytest_cache/
). I noticed that even if the--skip-bad-files
option was used, Pycco would still fail to generate the documentation. Removing the cached files is an option of course, but in my opinion Pycco should treat those files as bad files.Given a
.pytest_cache
dire.tory (AFAIK it should be generate by Pytest when running the tests), the new behavior is the following,With the
--skip-bad-files
optionWithout the
--skip-bad-files
option