search

pychess / pychess

PyChess - a chess client for Linux/Windows
https://pychess.github.io/
GNU General Public License v3.0
697 stars 185 forks source link

Translation strings not available in development version #415

Closed pychess closed 9 years ago

pychess commented 9 years ago

Original issue 415 reported by igor2x 2009-03-11

What steps will reproduce the problem?

  1. I downloaded source code from subversion system
  2. I have generated po file from glade and python files
  3. I have merged po files: old translation and new translation
  4. I have translated all (100%) of strings to my language
  5. I have created mo file
  6. Copied mo file to language location path
  7. Start PyChess and there are some strings that are not translated and as I see not included in generated translation po file. a) Settings | Preferences | "Sidepanels" tab is not translated b) Settings | Preferences | Sidepanels tab | Disable button is not translated c) Connect to FICS | "Adjourned" tab is not translated d) Connect to FICS | "Adjourned" tab | all of the buttons (Preview, Abort, Draw, Resign, Resume) are not translated e) Connect to FICS | "Adjourned" tab | Is online | "False" & "True" are not translated.

What is the expected output? What do you see instead? Instead of Slovenian translation I see English words. I have searched po files for above strings and this strings are missing.

Does it happen every time? Yes

What version of the product are you using? development version from source subversion system

Did you use an installed version of PyChess or did you run in from a tarball/svn? svn

pychess commented 9 years ago

Original comment 3. posted by igor2x 2009-03-11

I have searched the po file for above strings and this strings are not available. It looks like generating po file misses some of the strings.

pychess commented 9 years ago

Original comment 4. posted by gbtami 2009-03-12

Seems these strings are not yet marked for tranlation yet.

pychess commented 9 years ago

Original comment 5. posted by igor2x 2009-03-19

gbtami, is there a lot of work to mark this strings for translations? I would love to see this few strings included, that I can translate. :)

pychess commented 9 years ago

Original comment 6. posted by gbtami 2009-03-19

Not a big work, I will do. But I have to say, I don't know whether these part of code will be in the final 0.10 release. At least the sidepanel tab has issues: http://code.google.com/p/pychess/issues/detail?id=348

pychess commented 9 years ago

Original comment 7. posted by igor2x 2009-03-19

gbtami, if it is not a big bother it would be nice if this will be in 0.10 alfa. If the code will not be stable enough for final release there will not be any problem, just some strings that would be translated too much.

pychess commented 9 years ago

Original comment 8. posted by gbtami 2009-03-19

I'v just committed some more translatable strings to svn. Can you please test it, and report if i missed something. thx

pychess commented 9 years ago

Original comment 9. posted by igor2x 2009-03-19

Hi, I have downloaded new version from svc, generated new .po file, merged old .po with new .po and look into change.

  1. All above strings in my first post are included in new .po file except this one (False, True is not translated): Connect to FICS | "Adjourned" tab | Is online | "False" & "True" are not translated.

2. Game | New game | Time Control

It looks like following two strings are partially translated instead of whole string. It looks like in program there are multiple strings instead of just one that is available in .po file (.po file has correct string).

: glade/newInOut.glade:612

msgid "Rapid:\t15 min + 10 sec/move"

: glade/newInOut.glade:678

msgid "Normal:\t40 min + 15 sec/move"

3. Game | New game | Time Control

Click on icon at right site. Window opens with Minutes: and Gain: Gain is not translated althrough it is included in .po file and I have translated the string.

: glade/fics_lounge.glade:2282

msgid "Gain:"

4. Game | New game | Chess Variant

Second and third string:

: glade/newInOut.glade:945

msgid "Play Lossers chess"

Regards

pychess commented 9 years ago

Original comment 10. posted by igor2x 2009-03-19

Hi, by the way, I have attached new Slovenian translation to http://code.google.com/p/pychess/issues/detail?id=404 See last post and download attachment PyChess_slovenian_translation_version_2.tar.gz Untar file and cd to ver_0.10 where there are new .po and .mo files.

pychess commented 9 years ago

Original comment 11. posted by gbtami 2009-03-19

igor2x, thx for testing the new template.po! I will look after the remaining issues.

pychess commented 9 years ago

Original comment 12. posted by igor2x 2009-03-20

Hi, instead of my 4 suggestion - to create one string for all text, it could also be: Play chess: No castle and then just change "No castle" with "Lossers" etc and have very little to change - no new strings.

This would make more sense in translation where words order of string is important. Regards

pychess commented 9 years ago

Original comment 13. posted by igor2x 2009-03-20

Hi, add 1) maybe instead of True/False in Connect to FICS | "Adjourned" tab | Is online | "False" & "True" that are not translated could be "Yes/No". You know "Yes/No" is more friendly, "True/False" is too computer oriented. So I suggest to use Yes/No variant. Regards

pychess commented 9 years ago

Original comment 14. posted by gbtami 2009-03-20

New round. Fixed in several places, including the gettext suggestions. We have some places with "min" string yet, but that's enough for today :)

pychess commented 9 years ago

Original comment 15. posted by igor2x 2009-03-20

Hi, all above problems are now correctly solved. I have translated them to Slovenian and changed/approved all changes.

I have attached new Slovenian translation to http://code.google.com/p/pychess/issues/detail?id=404 See last post and download attachment PyChess_slovenian_translation_version_3.tar.gz Untar file and cd to ver_0.10 where there are new .po and .mo files.

pychess commented 9 years ago

Original comment 16. posted by igor2x 2009-03-20

Found new untranslated strings:

  1. Connect to FICS. First tab | Type the content of type is not translated: Blitz, Standard, Lighting, etc
  2. The same for 4 tab also type content not translated.
  3. The same for 2 tab pointing to blue circles: Blitz, Standard etc not translated
pychess commented 9 years ago

Original comment 17. posted by igor2x 2009-03-21

Hi, I have found one more string that is not translated. If game gets adjourned and I close the window I get warning message. Please see attached picture. I have made square around not translated strings.

pychess commented 9 years ago

Original comment 18. posted by igor2x 2009-03-21

Yesterday I have suggested to change True/False from FICS game Adjourned tab to Yes/No, but now I have found there is on Seeks/Chalangers Rating tab which has "Rated/Untrated" content. This is better idea. So I suggest if you can rename Yes/No buttons at Adjourned tab in Is online column to "Online/Not online".

pychess commented 9 years ago

Original comment 19. posted by gbtami 2009-03-21

Another round. Fixed the missing ones on save dialog, changed yes/no to online/not online, and fixed the ngettext() usage for plural forms.

Regarding the chess type names (standard/blitz/etc.) i suggested this before to Thomas, but he argued that these are not in our code, but coming from a FICS server, and it can be a german or any other localized server. Maybe we can try to translate these if they are in english, and don't touch otherwise.

pychess commented 9 years ago

Original comment 22. posted by igor2x 2009-03-21

Hi, thanks a lot. I have translated this new strings and uploaded file to http://code.google.com/p/pychess/issues/detail?id=404 See last post and download attachment PyChess_slovenian_translation_version_4.tar.gz Untar file and cd to ver_0.10 where there are new .po and .mo files.

A world about singular/plural. You added this one now when I found out there is untranslated save dialog: "There are %d games with unsaved moves. Save changes before closing?" I don't like this approach of singular/plural, because it doesn't line up with all languages, especially Slovenian, which is one of the most complicated languages in the world. You see in Slovenian language there are not only singular and plural, but there is also dual (for two people). Slovenian is one or two of the languages in the world that has duality. But this is not the only problem. In Slovenian language last letter (or last two letters) of word is changing according to the numbers of items for example igra (= game) has this variations according to number of items: 1 igra (one game), 2 igri (two games), 3 igre (tree games), 4 igre (four games) 5 iger (five games). What is more "beautiful" last latter is gender dependent (English doesn't have such a gender dependencies). So what I propose is to use only one variant, for example for above string use: "There is at least one game with unsaved moves. Save changes before closing?" This is independent of number of games to save. I also see no point of telling user how many games he have unsaved if he can't choose which one to save and which one not to save.

About chess type names, it would be nice if for English worlds could exist localization. Maybe fics server supports more languages, so it could get translated word from server in the first place. But if it is too much bother don't do it, it is not so important. Regards

pychess commented 9 years ago

Original comment 23. posted by gbtami 2009-03-22

I'v changed the Plural-forms in your .po header according to http://www.gnu.org/software/hello/manual/gettext/Plural-forms.html#Plural-forms and added some "games" translations. Seems to work ok for me. Please correct them as needed. I know very little slovenian, just recognize a few worlds which similar enough to russian :)

pychess commented 9 years ago

Original comment 24. posted by gbtami 2009-03-22

pychess commented 9 years ago

Original comment 25. posted by igor2x 2009-03-23

gbtami, thanks a lot. I have translated this two new strings and uploaded file to: http://code.google.com/p/pychess/issues/detail?id=404

pychess commented 9 years ago

Original comment 26. posted by igor2x 2009-03-23

Hi, found another untranslated tag. :)

In thread http://code.google.com/p/pychess/issues/detail?id=421 I requested for FICS

Adjourned > Date/Time string and lobais has added this new string. Can you please add this new string to subversion, that I can translate. Thanks

pychess commented 9 years ago

Original comment 27. posted by gbtami 2009-03-24

Another round. Please tell me if any translatable string wants ngettext() (for plural) instead of _().

pychess commented 9 years ago

Original comment 28. posted by igor2x 2009-03-24

gbtami, in thread http://code.google.com/p/pychess/issues/detail?id=404 I have uploaded new translated untar and look into ver_0.10 directory

pychess commented 9 years ago

Original comment 31. posted by igor2x 2009-03-24

For now I think all problems are solved. If there is some untranslated text I will let you know. Thanks a lot, for making such a good software and gave me a change to translate it.

pychess commented 9 years ago

Original comment 32. posted by gbtami 2009-03-25