pycom / pycom-libraries

MicroPython libraries and examples that work out of the box on Pycom's IoT modules
330 stars 379 forks source link

Update dev_addr coding #115

Closed frahlg closed 3 years ago

frahlg commented 4 years ago

(Hi! 👋 Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

The ABP dev address from TTN needs to be converted from little to big endian. Previous code didn't work. Also updated to use the ustruct and ubinascii libraries.

Does this close any currently open issues?

Any relevant logs, error output, etc?

(If it’s long, please paste to https://gist.github.com and insert the link here)

Any other comments?

Where has this been tested?

frahlg commented 4 years ago

The ABP dev address from TTN needs to be converted from little to big endian. Previous code didn't work. Also updated to use the ustruct and ubinascii libraries.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

gijsio commented 3 years ago

Hi, Im not experiencing any issues with the current setup, nor did we receive any reports of the functionality not working as is. Therefore, I will close your PR here. Please re-open it if you think differently!

Gijs