V1.20.0.rc7: Build for Fipy fails with undefined reference

pycom / pycom-micropython-sigfox

A fork of MicroPython with the ESP32 port customized to run on Pycom's IoT multi-network modules.

MIT License

199 stars 167 forks source link

V1.20.0.rc7: Build for Fipy fails with undefined reference #263

Closed robert-hh closed 5 years ago

robert-hh commented 5 years ago

Fails with OPENTHREAD = off. Error message:

LINK build/FIPY/release/application.elf
build/FIPY/release/application.a(modlte.o):(.literal.TASK_LTE_UPGRADE+0xc): undefined reference to `xMeshTaskHndl'

xMeshTaskHndl is not defined in the sources and not in esp-idf, branch idf_v3.1. Updating esp-idf does not change the picture. Building for LoPy4, LOPY, GPY and WiPy works.

iwahdan88 commented 5 years ago

Hi @robert-hh , thanks for reporting this, you are correct in modlte.c line 319 should be conditioned like this

#ifdef LORA_OPENTHREAD_ENABLED
    vTaskSuspend(xMeshTaskHndl);
#endif

we will update it asap

robert-hh commented 5 years ago

Tested & it works

Xykon commented 5 years ago

I also created a PR for this https://github.com/pycom/pycom-micropython-sigfox/pull/264

robert-hh commented 5 years ago

Thanks. But If I was the only one noticing that as a problem, then a separate branch would not have to be used. I made that change anyhow already before posting the issue. Now there is another branch in the repository, which will be abandoned soon. At least, GIT makes it easy to deal with such variants.