search

pycom / pycom-micropython-sigfox

A fork of MicroPython with the ESP32 port customized to run on Pycom's IoT multi-network modules.
MIT License
197 stars 167 forks source link

User C modules : enable in Makefile and application.mk #471

Closed rcolistete closed 3 years ago

rcolistete commented 3 years ago

User (External) C modules are not currently enabled in Pycom MicroPython (August 6th 2020) because 'esp32/Makefile' and 'esp32/'application.mk' don't use 'SRC_MOD', 'CFLAGS_MOD', 'LDFLAGS_MOD' and 'CFLAGS_EXTRA'.

This PR fix this issue, inserting 'SRC_MOD', 'CFLAGS_MOD', 'LDFLAGS_MOD' and 'CFLAGS_EXTRA' in correct places of 'esp32/Makefile' and 'esp32/'application.mk' so that user (external) C modules can be built when compiling the Pycom firmware.

robert-hh commented 3 years ago

Good luck with that useful PR. Pycom has a somewhat stealthy method of dealing with PR's. So your PR may sit there longtime seemingly unnoticed until eventually the content is used in a Pycom code update, honestly mentioning you.

rcolistete commented 3 years ago

Good luck with that useful PR. Pycom has a somewhat stealthy method of dealing with PR's. So your PR may sit there longtime seemingly unnoticed until eventually the content is used in a Pycom code update, honestly mentioning you.

Hope to see this PR merged. It is very useful to allow more community contributions to Pycom MicroPython.

"pycom-micropython-sigfox/py/py.mk" already supports USER_C_MODULES, so 'SRC_MOD', 'CFLAGS_MOD' and 'LDFLAGS_MOD' are modified with content from user C modules. So it is just some lines missing in 'esp32/Makefile' and 'esp32/'application.mk' that currently blocks the use of 'user (external) C modules' in Pycom MicroPython.

peter-pycom commented 3 years ago

lgmt thanks. internal PR: https://github.com/pycom/Firmware-Development/pull/175

peter-pycom commented 3 years ago

Thanks again @rcolistete . It has been merged and released