pyconca / 2013-web

a Django project for conference websites
https://2013.pycon.ca/
BSD 3-Clause "New" or "Revised" License
6 stars 9 forks source link

Talk proposals show up as "TalkProposal object" in admin #77

Open felixc opened 11 years ago

felixc commented 11 years ago

In the Admin section for managing talk proposals, everything shows up as "TalkProposal object". It would be more useful for the model's string representation to be something like "Author Name: Title Of This Talk".

dianaclarke commented 11 years ago

Yup. This is the symposion default. This is already on the list to be fixed by the contractor for the PyCon USA branch. That might not be in time for us though.

MichaelDiBernardo commented 11 years ago

This should be a super easy fix -- just override unicode in TalkProposal model object!

I'll see if I can get to it tonight.

On 2013-06-02, at 5:36 PM, diana wrote:

Yup. This is the symposion default. This is already on the list to be fixed by the contractor for the PyCon USA branch. That might not be in time for us though.

— Reply to this email directly or view it on GitHub.

dianaclarke commented 11 years ago

Apparently, it's not that easy. I thought so at first too...

dianaclarke commented 11 years ago

When I suggested the same thing a month ago, I was told:

""" You could not have fixed the old admin due to the way that Pinax manages things. It does not behave like a normal django site/application, and making admin changes would end up breaking the system in most cases as almost all objects are tied to other objects and need to be edited in concert. Why I gave up long ago. """

MichaelDiBernardo commented 11 years ago

Sorry about that last pull request, I totally thought I was working on my own fork. Turns out you guys gave me commit privileges to the repo and I didn't even notice. Bad idea :)

Anyhow, can someone check out https://github.com/pyconca/2013-web/commit/a4bacf437c3a9e5fead2facc0477966791c857f2 ? Diana, I totally believe what your source was saying, but I checked this out locally in shell as well as in local admin and it seemed to be just fine.

MichaelDiBernardo commented 11 years ago

Argh, specifically https://github.com/pyconca/2013-web/commit/a4bacf437c3a9e5fead2facc0477966791c857f2#L0R133 -- sorry, my editor obliterates trailing whitespace, and it seems there was a lot of that in the files I edited :)