search

pycontribs / ansi2html

Convert text with ansi color codes to HTML
GNU Lesser General Public License v3.0
387 stars 78 forks source link

Add test coverage #148

Closed ziegenberg closed 2 years ago

ziegenberg commented 3 years ago

Adds test coverage data

ziegenberg commented 2 years ago

This is ready for review.

ssbarnea commented 2 years ago

If you want to complete the coverage enablement, try to also upload the data to codecov.io -- You can inspire from https://github.com/ansible-community/ansible-compat/blob/main/.github/workflows/tox.yml#L217-L222 -- it is a little bit dated but still works.

I will enable codecov integration and we will see jobs reporting when coverage goes down.

ziegenberg commented 2 years ago

I will try to add the according workflow steps.

ziegenberg commented 2 years ago

I will look into this a bit later this week.

ssbarnea commented 2 years ago

I will look into this a bit later this week.

No hurry, fixing stuff in small steps is the best approach as we never know how much time we have available. I mentioned that only for follow-ups, it was not a required for enablement.

Still, this needs to report green to merge it.

ziegenberg commented 2 years ago

I'll revert 9387334b3ed621bcfbfbe9fd0f035d3143294311 for now and will add this via it's own PR later on.