search

pycontribs / ansi2html

Convert text with ansi color codes to HTML
GNU Lesser General Public License v3.0
387 stars 78 forks source link

Remove python3.6 support #190

Closed dvzrv closed 1 year ago

dvzrv commented 1 year ago

Remove support for Python 3.6 as it is not supported by upstream anymore.

dvzrv commented 1 year ago

screenshot-2022-11-18_16-36-30

hmm :thinking:

hartwork commented 1 year ago

screenshot-2022-11-18_16-36-30

hmm :thinking:

@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in git rebase -i HEAD~2) or close and re-open of the PR, in hope that GitHub fixes itself about this. What do you think?

dvzrv commented 1 year ago

@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in git rebase -i HEAD~2) or close and re-open of the PR, in hope that GitHub fixes itself about this. What do you think?

I tried with touching the commit messages, but I guess this is just some weird thing with github actions probably...

hartwork commented 1 year ago

@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in git rebase -i HEAD~2) or close and re-open of the PR, in hope that GitHub fixes itself about this. What do you think?

I tried with touching the commit messages, but I guess this is just some weird thing with github actions probably...

@dvzrv Weird and buggy, yes. Would you be up to try…

for i in 1 2 ; do git revert --no-edit HEAD~1 ; done
git push .......

with two reverting commits more to see if the CI heals and then try again with the reverts dropped. Just an idea.

hartwork commented 1 year ago

PS: @dvzrv the overall diff would be empty then, maybe add some bogus change on top so that GitHub won't close the PR or something. Just thinking aloud...

ssbarnea commented 1 year ago

Don't worry about required, I fix that.

hartwork commented 1 year ago

Don't worry about required, I fix that.

@ssbarnea how?

ssbarnea commented 1 year ago

But I am worried about not seeing any file updated. I was expecting metadata updated and GHA jobs removed.

dvzrv commented 1 year ago

Okay, but this seems to have fixed it now (I have removed the dummy commit on top).

hartwork commented 1 year ago

But I am worried about not seeing any file updated. I was expecting metadata updated and GHA jobs removed.

@ssbarnea that's from the revert commits put in by @dvzrv in the meantime, see https://github.com/pycontribs/ansi2html/pull/190#issuecomment-1320341645 .