search

pycontribs / ansi2html

Convert text with ansi color codes to HTML
GNU Lesser General Public License v3.0
387 stars 78 forks source link

Restore man page rendering dropped by pull request #194 #193

Open ssbarnea opened 1 year ago

ssbarnea commented 1 year ago

Apparently https://github.com/asciidoc-py/asciidoc-py is declared legacy and have lots of problems, including inability to parse current version of the specification or to work under MacOS.

In order to be able to setup the CI pipeline on the project we will just remove all its use and look for help to get someone to provide an alternative.

hartwork commented 1 year ago

@ssbarnea I won't be able to bump to 1.9.0rc1 in Gentoo without a man page. Man page rendering was working fine in CI before 98ce41fbf3073d4db0da4e8678e7a12d6f5d2442 and now we have a release without a man page just because of that refactoring. Let's not break things like that next time and discuss upfront please. Thank you.

Related: #194

hartwork commented 1 year ago

PS: @ssbarnea while asciidoc-py is marked legacy, it has its latest release 10.2.0 in 2022-05 and homebrew has that version packaged. Could you share what error you get when rendering the man page on macOS with latest asciidoc-py? PPS: The alternative to asciidoc-py is https://github.com/asciidoctor/asciidoctor but it's written in Ruby.

ssbarnea commented 1 year ago

@hartwork Please make a PR to restore the functionality, GHA is also running on macos so we should see the results.

TBH, I was horrified about the behavior and the lack of info on how to address, that is why I just disabled the page, temporary. Let's fix it before the release!

I am also inclined to switch to markdown like mkdocs for documentation but I need to find a solution to generate the man page from these. More than open to suggestions.

hartwork commented 1 year ago

@ssbarnea