pycontribs / django-alexa

Amazon Alexa Skills Kit integration for Django -- ARCHIVED contact @ssbarnea if you can resurrect it.
https://github.com/pycontribs/django-alexa/issues/37
MIT License
69 stars 51 forks source link

Python 3 support #22

Open Nizebulous opened 7 years ago

Nizebulous commented 7 years ago

Pretty self-explanatory here. ;-)

ekimia commented 7 years ago

Looks like you added support for it on the master branch! Anything barring a new release?

ekimia commented 7 years ago

@rocktavious ^

JooeunAhn commented 7 years ago

Is this app supporting python3?

hairychris commented 7 years ago

This pull request added support for Python 3 https://github.com/pycontribs/django-alexa/pull/23

That's why tox has a target for it: https://github.com/pycontribs/django-alexa/blob/master/tox.ini

JooeunAhn commented 7 years ago

Thanks for reply 👍

lingster commented 5 years ago

should we consider removing support for python 2.7, given that Django >=2.x no longer supports legacy python 2.x ?

rocktavious commented 5 years ago

Hey All - unfortunately i'm no longer doing Alexa skills development work so i can no longer maintain this - i gave the repo over to pycontribs in hopes that someone else who is doing Alexa skills development could take over ownership - if any of you are doing consistent Alexa skills dev work i'm happy to add people as collaborators so they can take more ownership over this repo.

lingster commented 5 years ago

Hi @rocktavious, I'd be happy to help contribute to the maintenance and support of this project. I'm currently working on building alexa skills so happy to provide updates to this project and replies to the issues and pr. What are the requirements to become a collaborator?

rocktavious commented 5 years ago

@lingster I sent you an invite to be a collaborator on this repo specifically - it basically gives you admin privileges over this repo - but optionally you can also reachout to the pycontribs community and ask to be added to the pycontribs org in github and that will give you admin too (as well as admin on other pycontribs repos) - The PyContribs organization has their default repository permission set to admin. This means that every member of this organization has admin access to this repository, regardless of the team and collaborator access specified.

lingster commented 5 years ago

@rocktavious thanks for adding me as admin, I'm trying to fix an issue with the travis ci status which is detailed here: https://github.com/travis-ci/travis-ci/issues/10204. It seems that the build status of travis ci is not correctly being updated in git up. This can by fixed by updating the branch protection settings. https://github.com/pycontribs/django-alexa/settings/branches. However I don't have permissions to do this. Can you help to take a quick look and fix that? Currently we won't be able to merge any PRs till this is done.

rocktavious commented 5 years ago

@lingster Sorry looks like the collab invite only gave your "write" permissions - i've elevated you to "admin" now

lingster commented 5 years ago

@rocktavious thanks for the update, I can confirm that I am able to update the PR settings and able to verify and accept PR - long live django-alexa!

lingster commented 5 years ago

@rocktavious Would it be possible to give me permissions in pypi to be able to publish new versions of django-alexa? my pypi login in lingster. I've also ported your pyversion so that it runs in python 3.6 the repo is here: https://github.com/lingster/pyversion3. I see that the original pyversion has been archived. Would it be possible to move this to pycontribs and I can merge my changes back to that, and potentially provide me with admin/maintainer status so this can be maintained?

rocktavious commented 5 years ago

Hey @lingster I've done the following:

Unfortunately i've stopped doing python development for work so most of this stuff has fallen by the wayside so thank you very much for taking up the torch of ownership and looking after these code babies of mine ;)

Let me know if there is anything else you need!

Cheers!