search

pycontribs / jenkinsapi

A Python API for accessing resources and configuring Hudson & Jenkins continuous-integration servers
http://pypi.python.org/pypi/jenkinsapi
MIT License
859 stars 485 forks source link

ArtifactBroken exception raised with matching fingerprint #711

Closed stefano913 closed 5 years ago

stefano913 commented 5 years ago
ISSUE TYPE
Jenkinsapi VERSION

0.3.9

Jenkins VERSION

2.164.3

SUMMARY

calling grab_artifact or get_artifacts with short (i.e. not full) job name causes a ArtifactBroken exception in Artifact::save being raised inside self._verify_download even when the md5sum is matching.

EXPECTED RESULTS

Should not raise the exception

ACTUAL RESULTS

It raises an ArtifactBroken exception

USEFUL INFORMATION

In Artifacts::verify_download self.build.job.name (rather than self.build.job.get_full_name()) should be passed to validate_for_build at line 98-99 in artifact.py. validate_for_build will return False otherwise, as the expression usage_item["name"] will not match job at line 86 of fingerprint.py.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

Closed due to inactivity