search

pycontribs / jenkinsapi

A Python API for accessing resources and configuring Hudson & Jenkins continuous-integration servers
http://pypi.python.org/pypi/jenkinsapi
MIT License
859 stars 485 forks source link

Fixes #430: Validate an artifact using "hash" rather than "fileName" #851

Open plastikos opened 11 months ago

plastikos commented 11 months ago

Jenkins only stores one version of an artifact by its hash and by the original filename. Subsequent stores of an artifact with an identical hash but different filename will point to the original artifact. If a duplicate artifact (identical hash) has a different filename than the original filename then that new filename will be stored as a name in the build artifacts but will not change the fileName of the original artifact. This makes it problematic to compare against the original fileName when validating a build artifact that has been saved.

Since the md5sum hash is computed for the local, saved artifact it can be compared against the Jenkins artifact ID (viz hash) for validation. This avoids the problem of identical artifacts having additional filenames. Using the hash is also a better way of validating data integrity rather than using the fileName even when the filename matches.

plastikos commented 11 months ago

I see lots of failures with the checks but I can't find any logs that indicate what failed. Are the checks broken?

plastikos commented 11 months ago

What's up with the pre-commit.ci changing the P.R.?

plastikos commented 11 months ago

This P.R. will close #709 as well as #430.