pycontribs / jira

Python Jira library. Development chat available on https://matrix.to/#/#pycontribs:matrix.org
https://jira.readthedocs.io
BSD 2-Clause "Simplified" License
1.95k stars 869 forks source link

Move away from using the imghdr module as it is deprecated & will be removed in 3.13 https://docs.python.org/3/library/imghdr.html #1557

Open dbaxa opened 1 year ago

dbaxa commented 1 year ago

Bug summary

Hi, as per away https://docs.python.org/3/library/imghdr.html the imghdr module is deprecated as of python 3.11 & will be removed in python 3.13.

Is there an existing issue for this?

Jira Instance type

Jira Cloud (Hosted by Atlassian)

Jira instance version

No response

jira-python version

main

Python Interpreter version

3.11

Which operating systems have you used?

Reproduction steps

1. Install jira in python 3.11
2. Import it
3. <path>jira/client.py:11: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
    import imghdr

### Stack trace

```python
<path>jira/client.py:11: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
    import imghdr


### Expected behaviour

No deprecation warning is raised.

### Additional Context

_No response_
tomereli commented 1 year ago

Any update on this? we can't this is failing pytest when we enable warnings as errors.

tibu commented 1 year ago

Do you know when this change could be part of a release?

NasaGeek commented 9 months ago

Looks like 3.6.0, released last week, addressed this issue. I expect this can be closed.

deronnax commented 9 months ago

@adehad you can safely close this one as it was addressed by the merged #1680