search

pycontribs / jira

Python Jira library. Development chat available on https://matrix.to/#/#pycontribs:matrix.org
https://jira.readthedocs.io
BSD 2-Clause "Simplified" License
1.94k stars 860 forks source link

fix verify not sent with request (#1573) #1631

Closed jongracecox closed 1 year ago

jongracecox commented 1 year ago

This commit fixes an issue where the verify option is not passed along with requests issued by the ResilientSession class. This commit adds the verify option into the request args inside the _jira_prepare function.

The commit includes a unit test that verifies that session.verify is correclty handed over to requests during subsequent Jira API calls.

jongracecox commented 1 year ago

Could someone please add the bug label to this PR? I don't have permission to do so.

studioj commented 1 year ago

thanks for the PR

jongracecox commented 1 year ago

It's not clear to me why the ci / cloud / py3.8 tests are failing, but I notice the same errors on other PRs (#1528), so wonder whether this is not specific to this PR.

jongracecox commented 1 year ago

It's not clear to me why the ci / cloud / py3.8 tests are failing, but I notice the same errors on other PRs (#1528), so wonder whether this is not specific to this PR.

I assume it because my PR doesn't have access to the project secrets, so doesn't need anything fixed from my side.

adehad commented 1 year ago

It's not clear to me why the ci / cloud / py3.8 tests are failing, but I notice the same errors on other PRs (#1528), so wonder whether this is not specific to this PR.

I assume it because my PR doesn't have access to the project secrets, so doesn't need anything fixed from my side.

Exactly the case, sorry for the delay. Thanks for the great quality PR!