search

pycontribs / jira

Python Jira library. Development chat available on https://matrix.to/#/#pycontribs:matrix.org
https://jira.readthedocs.io
BSD 2-Clause "Simplified" License
1.95k stars 864 forks source link

fix: small fix for dev docker #1786

Closed studioj closed 9 months ago

studioj commented 9 months ago

bumping to focal (hirsute is not maintained anymore) and libkrb5 was needed otherwise there were weird install errors after running tox

adehad commented 9 months ago

I think the key is to change the .devcontainer.json file as that overrode the variable in the Dockerfile.

Ran a test now where I built the devcontainer from that branch and it seems to have worked as expected: image

It successfully used the jammy version and installed the project

adehad commented 9 months ago

Regarding the test failing, I think it is now how when deleting a project the project does not get permanently deleted, but exists in a 'trash', so it is still 'found' by some endpoints but not others. A bit weird I thought I fixed with the right new parameter, but it seems not?

studioj commented 9 months ago

sorry for making this more than a 'small fix'

was intending to do a small one but then i saw CI failing :D