search

pycontribs / jira

Python Jira library. Development chat available on https://matrix.to/#/#pycontribs:matrix.org
https://jira.readthedocs.io
BSD 2-Clause "Simplified" License
1.91k stars 856 forks source link

Add issue.remove_field_value() #1834

Open nickbroon opened 4 months ago

nickbroon commented 4 months ago

Complements the existing add_field_value()

adehad commented 3 months ago

@nickbroon thanks for this! Do you think we can add a test (to: tests\resources\test_issue.py) where perhaps we

  1. add the value (perhaps to the label field)
  2. check the value is added
  3. remove the value
  4. check the value is removed ?
nickbroon commented 2 months ago

thanks for this! Do you think we can add a test (to: tests\resources\test_issue.py) where perhaps we

  1. add the value (perhaps to the label field)
  2. check the value is added
  3. remove the value
  4. check the value is removed ?

adehad, I pushed a update to the Pull Request that adds a test that exercises both remove_field_value() and add_field_value()

nickbroon commented 3 weeks ago

The UT failures look unrelated to the changes in the PR.