search

pycontribs / jira

Python Jira library. Development chat available on https://matrix.to/#/#pycontribs:matrix.org
https://jira.readthedocs.io
BSD 2-Clause "Simplified" License
1.92k stars 857 forks source link

adding warning when requests_futures isnt installed #1863

Open RichieCahill opened 1 month ago

RichieCahill commented 1 month ago

This is a super small pr. I dont think it requires any new tests because of its nature. Please let me know if I did anything wrong.

dimitarOnGithub commented 1 week ago

@adehad / @studioj this one looks good to me as-is, but I wonder if the constructor would be a better place for this warning considering it wouldn't be visible until the code attempts to execute the _fetch_pages method? I think it'd be better if the import, along with the assignment of the async_workers and async_class, happens in the constructor itself, that way you get an instant warning that a requirement is missing.