deactivate_user returns True, but the user is not deactivated.

Strekerud commented 7 years ago

Deactivating users was introduced in this PR: https://github.com/pycontribs/jira/pull/217

The below code returns True, but the user is not deactivated in Jira, and the user is still counted towards the license.

from jira import JIRA

jira = JIRA(server='serverurl_here', basic_auth=(''user, pw''))

jira.deactivate_user("user_to_be_deactivated")

We're running Jira 6 (v6.2.5) on a non-cloud instance.

E14 commented 7 years ago

Also happens on 7.1, also passing active=False when creating a user has no effect. No error shown. JIRA log sez:

Absolutely nothing! :)

However, the method does not call a REST API, as visible through access logs, like:

<IP> 903x280x1 <user> [02/Mar/2017:15:03:56 +0100] "POST /secure/admin/user/EditUser.jspa HTTP/1.1" 200 1114 117 "-" "python-requests/2.12.4" "<some-id>"

So I thought it might require a separate websudo and bingo:

jira._gain_sudo_session({}, '/')
jira.deactivate_user('foobar')

this worked!

jira.user("foobar").active
>> False

ahmedsajid commented 7 years ago

@E14 do you know to activate the user after deactivation? gain_sudo_session worked for me. Thanks for the pointer.

E14 commented 7 years ago

@ahmedsajid Yes, I had to solve that too. I have extended "JIRA" so self is the jira object. It will also require a _gain_sudo_session(...) before calling it, I've deliberately duplicated the behaviour of existing functions that operate on admin-interface forms in this.

The below code is mostly (save the error logging part) ready to include into the project as well. (Unless there are some Python 2 incompatibilities)

def activate_user(self, username):
    """Enable/activate the user."""
    url = self._options['server'] + '/secure/admin/user/EditUser.jspa'
    self._options['headers']['Content-Type'] = 'application/x-www-form-urlencoded; charset=UTF-8'
    user = self.user(username)
    userInfo = {
        'inline': 'true',
        'decorator': 'dialog',
        'username': user.name,
        'fullName': user.displayName,
        'email': user.emailAddress,
        'editName': user.name,
        'active': 'true'
    }

    try:
        r = self._session.post(url, headers=self._options['headers'], data=userInfo)
        if r.status_code == 200:
            return True
        else:
            logging.warning(
                'Got response from activating %s: %s' % (username, r.status_code))
            return r.status_code
    except Exception as e:
        print("Error Activating %s: %s" % (username, e))

ahmedsajid commented 7 years ago

@E14 Thank you very much!

asqui commented 7 years ago

Do you want to submit a pull request to have this incorporated into the next release?

E14 commented 7 years ago

@asqui actually, not yet, feel free to put it in, if you want to have it in now already, but for me there are some questions open (logging, proper exceptions, Jira version/Python compatibility, ... more?), and I'm rewriting this method soon anyway to put in a possibly more controversial addition of _ensure_sudo_session()