search

pycontribs / pyrax

The Python SDK for the Rackspace Cloud
developer.rackspace.com
Apache License 2.0
237 stars 208 forks source link

Fix #590: _resolve_device_type() doesn't recognise CloudServer #591

Closed kynx closed 8 years ago

kynx commented 8 years ago

Sorry, couldn't see how to add a test for this - the existing tests use fakes.FakeDNSDevice() which is why they don't pick up on the problem. But this does it for me :smile:

kynx commented 8 years ago

Oh, and so the links are loud and clear, this is a fix for #590.

kynx commented 8 years ago

Actually, digging a bit more it looks like __init__.py is the problem. Maybe it should be:

from novaclient.v2.servers import Server as CloudServer

From what I can tell the only place this is referenced is in clouddns...

kynx commented 8 years ago

Looks like this has been fixed in the latest release