search

pycontribs / pyrax

The Python SDK for the Rackspace Cloud
developer.rackspace.com
Apache License 2.0
237 stars 208 forks source link

Update references to novaclient 1.1 #594

Closed EdLeafe closed 8 years ago

EdLeafe commented 8 years ago

Recent releases of novaclient removed the references to the v1.1 client. This patch updates the import statements to refer to the v2 client, and also updates the check for the 1.1 extensions. The required version for python-novaclient has also been increased to use 2.27.0 as the minimum.

briancurtin commented 8 years ago

Looks alright, going to wait for @sivel to take a look.

sivel commented 8 years ago

I'll go ahead and assign this to myself. I likely will not get to it immediately, but I'll work on testing these changes and trying this out with the ansible integration tests as well.

ChrisHacker commented 8 years ago

@sivel That's fine, but this has been sitting here for almost a month. When will it be merged?

sivel commented 8 years ago

pyrax has been deprecated, and in a freeze. With another recently reported issue, I believe we will perform a release soon, to maintain functionality in Ansible. I will plan on including this fix and the other.

ChrisHacker commented 8 years ago

@sivel Is the OpenSDK ready for production use as its replacement? Last I checked, it wasn't. If it is, let me know. If not, as many others have previously noted, it's not a great idea to deprecate the library that everyone is using before releasing the new one and allowing for time to change over.

briancurtin commented 8 years ago

It's not a 1:1 replacement yet, but it is relatively complete and down to a few things to add before it hits 1.0 -- this is speaking for the upstream OpenStack SDK. With that, things like Cloud Servers, Cloud Files, Cloud Networks, are pretty complete as far as covering the API goes, and they work well. Things like Cloud Monitoring, which are not OpenStack but are proprietary Rackspace products, are going to be added to the Rackspace plugin to OpenStack SDK, but we don't have a timeline available for them at the moment.

ChrisHacker commented 8 years ago

@briancurtin As a fellow dev I get juggling legacy while building the future, but mixing 'pretty complete' with deprecating the prior library doesn't seem to be in the same ballpark as fanatical customer service. Disappointing.

sivel commented 8 years ago

Merged Thanks. I am going to make one change, in that I am going to pin python-novaclient explicitly to 2.27.0. Because we allow the release to be >= I feel that is at least a partial cause that we have to keep updating things related to novaclient.