search

pycontribs / pyrax

The Python SDK for the Rackspace Cloud
developer.rackspace.com
Apache License 2.0
237 stars 208 forks source link

Don't convert key to bytes on Python 3. Fixes #565. #607

Closed jaraco closed 8 years ago

jaraco commented 8 years ago

Disables the first clause on Python 3. I did test and setting a 'unicode' attribute of an object on Python 2 is also acceptable, but per the guidance on not changing Python 2 behavior, I'm leaving that undesirable code in place and only disabling it when not on Python 2, thus having zero impact on the officially-supported Python versions.

jaraco commented 8 years ago

I meant for this to be against working.

briancurtin commented 8 years ago

For whatever it's worth, I have no intention of supporting Python 3 as it would just give this project further legs in a time where we're working to move away from it. Of course this change by itself is fine, but there will be no wholesale porting effort.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 96.674% when pulling c72aff60924689d65384270f1c8309a7a65ef2ef on jaraco:issue-565 into b4691a3b1d4aa46892cf051c841995670f27aea6 on rackspace:master.