search

pycontribs / pyrax

The Python SDK for the Rackspace Cloud
developer.rackspace.com
Apache License 2.0
237 stars 208 forks source link

Don't convert key to bytes on Python 3. Fixes #565. #608

Closed jaraco closed 6 years ago

jaraco commented 8 years ago

Disables the first clause on Python 3. I did test and setting a 'unicode' attribute of an object on Python 2 is also acceptable, but per the guidance on not changing Python 2 behavior, I'm leaving that undesirable code in place and only disabling it when not on Python 2, thus having zero impact on the officially-supported Python versions.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 96.674% when pulling c72aff60924689d65384270f1c8309a7a65ef2ef on jaraco:issue-565 into e7d729f435adf8cae8f2bae48d04b00f910cdcd1 on rackspace:working.

nicholaskuechler commented 6 years ago

+1, the PR fixes some python3 issues I've hit.