search

pycontribs / python-crowd

A python client to the Atlassian Crowd REST API. ❗️seeking-new-maintainer
https://github.com/pycontribs/python-crowd
BSD 2-Clause "Simplified" License
45 stars 41 forks source link

Py3k Compatibility, and Travis CI testing #10

Closed lukecyca closed 11 years ago

lukecyca commented 11 years ago

Hi Again!

This fixes some py3k things, mostly in the crowdserverstub.py. I've also set up travis-ci to run the tests against Python 2.7 and 3.3 after every push.

If you don't have a travis account yet, here are roughly the steps to set it up on this repo:

  1. Follow the first two steps at http://about.travis-ci.org/docs/user/getting-started/
  2. Merge this pull request to get the .travis.yml file
  3. Watch travis build and test the repo
  4. Add the travis build status badge to the README

I set it up on my branch to make sure it all works: https://travis-ci.org/lukecyca/python-crowd

BTW: I've got a new package which depends on python-crowd: https://github.com/lukecyca/pyramid_crowd. I'm also considering making an crowd authentication module for Sentry.

aelse commented 11 years ago

Thanks for that. It'll be good to support python 3. I'll get to it in a few days when i have the chance to properly review.

lukecyca commented 11 years ago

Ping...

Did you have a chance to look at it? Let me know if there are any concerns.

aelse commented 11 years ago

Not yet. I'm in the tail end of a big chunk of work due tomorrow so I have just been pressed for time. I haven't forgotten about it.

lukecyca commented 11 years ago

ok, no worries!

aelse commented 11 years ago

Merged in commit 354312e

aelse commented 11 years ago

Works great, thanks!