search

pycontribs / python-crowd

A python client to the Atlassian Crowd REST API. ❗️seeking-new-maintainer
https://github.com/pycontribs/python-crowd
BSD 2-Clause "Simplified" License
45 stars 41 forks source link

Remove urllib, migrate to Request Sessions #13

Closed terinjokes closed 11 years ago

terinjokes commented 11 years ago

@aelse Do you have any comments on this PR? I'm happy to make relevant changes.

aelse commented 11 years ago

My only concern is that it adds a dependency on python-requests which isn't included by default in most (any?) distributions. That said, it is better to do that and resolve the hackiness in url construction. I'll merge it.

aelse commented 11 years ago

Thanks again for the contribution.

aelse commented 11 years ago

Actually, requests was already a requirement. My bad.