search

pycontribs / python-crowd

A python client to the Atlassian Crowd REST API. ❗️seeking-new-maintainer
https://github.com/pycontribs/python-crowd
BSD 2-Clause "Simplified" License
45 stars 41 forks source link

Changes as requested for pull request #19

Closed dobbscr closed 7 years ago

dobbscr commented 11 years ago

Have implement your comments ...think I got them all. Will do test cases once I get some time!!

aelse commented 11 years ago

Thanks for the work. There are a few outstanding problems.

The patch doesn't pass the existing unit tests. cd tests && python unittests.py. It looks like you've broken auth_user and committed it.

There's also some inconsistency between behaviour and docstrings (add_user_to_group and add_group return False not None) and I'm not sure what add_group returns (ie. what is in response that the api user needs, or is True sufficient?).

If you can address those things I'll look at it again but I won't be confident in it until I've had time to test it against a running Crowd server and written unit tests covering all new functionality.