search

pycontribs / python-crowd

A python client to the Atlassian Crowd REST API. ❗️seeking-new-maintainer
https://github.com/pycontribs/python-crowd
BSD 2-Clause "Simplified" License
45 stars 41 forks source link

Fix for #42 - Fix the params variable validationFactors when validating session #50

Closed maiko closed 5 years ago

maiko commented 5 years ago

This pull request address issue #42 "params variable is defined incorrectly on line 284"

Based on the recommendation by @mobile09 in #42, I've corrected line 284 in crowd.py and I was able to confirm that this fix is working as expected when validating a session with a user passing through a proxy.

I've encountered the same issue and fixed it internally, though it was a good idea to get it fixed upstream ;)

I've only bump the minor version since this is not a big change in functionality but only a fix.

Thanks, Maiko

maiko commented 5 years ago

Thanks for the merge @aelse. Do you plan on releasing the update to pypi ? Could be a good idea to get the fix out there ;)

Thanks !

aelse commented 5 years ago

@maiko I've just done a release.