search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

fix(reviews/views): use default alias for annotation #1010

Closed mattwang44 closed 3 years ago

mattwang44 commented 3 years ago

Types of changes

Description

Return 5XX when accessing the review portal with ordering by review count (<host>/<lang>/reviews/?order=count) as a reviewer. The error log is shown below:

image

The root cause is unknown but using default alias solves this issue.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1010 (777d016) into master (0fb1028) will increase coverage by 0.21%. The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   69.98%   70.20%   +0.21%     
==========================================
  Files          78       81       +3     
  Lines        3105     3131      +26     
==========================================
+ Hits         2173     2198      +25     
- Misses        932      933       +1
Impacted Files Coverage Δ
src/events/urls.py 0.00% <0.00%> (ø)
src/pycontw2016/urls.py 85.71% <ø> (ø)
src/reviews/views.py 33.33% <ø> (ø)
src/events/api/serializers.py 93.75% <93.75%> (ø)
src/events/api/urls.py 100.00% <100.00%> (ø)
src/events/api/views.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f749c6...777d016. Read the comment docs.