search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

Talk list API #1013

Closed setmao closed 3 years ago

setmao commented 3 years ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly self-describe enough about how you change the code.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. You may also want to refer to how to wirte the perfect pull request

codecov-commenter commented 3 years ago

Codecov Report

Merging #1013 (9c4eed2) into master (40b1529) will increase coverage by 0.17%. The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   70.21%   70.39%   +0.17%     
==========================================
  Files          81       81              
  Lines        3173     3192      +19     
==========================================
+ Hits         2228     2247      +19     
  Misses        945      945
Impacted Files Coverage Δ
src/events/api/urls.py 100.00% <ø> (ø)
src/events/api/views.py 67.64% <92.85%> (+6.93%) :arrow_up:
src/events/api/serializers.py 93.61% <94.11%> (-0.51%) :arrow_down:
src/proposals/models.py 88.28% <0.00%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40b1529...9c4eed2. Read the comment docs.

mattwang44 commented 3 years ago

@setmao please remember to fix the flake8 warning!