search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

chore: use sponsor name in en-us for open role api #1040

Closed mattwang44 closed 3 years ago

mattwang44 commented 3 years ago

Types of changes

Description

The sponsor name in open role API response is used by frontend and then passed to GA for counting the click on sponsor logo. The field is retrieved from db by the field name from sponsor model, but name_en_us is used in sponsor API, which cause the discrepancy between those two API and make it harder to joining those two metrics.

Update the open role API to unify the value of sponsor name to solve this issue.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1040 (6c47769) into master (8c719b8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          82       82           
  Lines        3291     3291           
=======================================
  Hits         2274     2274           
  Misses       1017     1017
Impacted Files Coverage Δ
src/sponsors/api/views.py 41.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c719b8...6c47769. Read the comment docs.