pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

[Review System] Clicked "Withdraw" button and a banner showed "Talk proposal with drawn", but the talk entry is not removed. #1071

Closed tai271828 closed 2 years ago

tai271828 commented 2 years ago

Description

To be honest I am not sure it's a bug or feature. I accidentally create a duplicate talk entry when submitting talks, and I would like to remove one of them. By clicking "Withdraw", I got a notification banner telling me that the talk proposal has been "withdrawn". However, I can still see the withdrawn talk proposal shown on my submitting dashboard.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Login the proposal review system
  2. Click +New Talk Proposal. Fill the necessary fields to create a proposal.
  3. Click +New Talk Proposal again to create another one.
  4. Click Withdraw button to withdraw one of them.

Expected Behavior

The withdrawn proposal has been removed.

Actual Behavior

The proposal still exists. The "Edit" button becomes "Reactivate".

Screenshots The picture shows the status of the buttons now. Selection_045

More Information

Desktop (please complete the following information):

Additional context

The UI and design of the submitting system is so beautiful!

mattwang44 commented 2 years ago

I believe it's a feature. If the submitters accidentally delete the wrong proposals, this feature gives them a chance to get them back (by pressing the reactivate btn). Also, the withdrawn proposals will not be sent to the review stage.

tai271828 commented 2 years ago

Thanks for the elaboration. I will close this issue then.