pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

Sposor order #1083

Closed Ritabear closed 2 years ago

Ritabear commented 2 years ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

排order,但回傳的時候別回傳order,而是後台排好。

Steps to Test This Pull Request

到Sponsor 的model 新增order=models.IntegerField(....) 後台admin新增欄位 到view.py order_by 新增 'order' ----> order_by('level', 'order')

Expected behavior

回傳的API會依廠商相同地位照著order自己排好

Related Issue

close #511

Ritabear commented 2 years ago

@mattwang44 麻煩你看看了 ><

codecov-commenter commented 2 years ago

Codecov Report

Merging #1083 (4f871a4) into master (8ce0fbb) will increase coverage by 0.00%. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   69.48%   69.49%           
=======================================
  Files          82       82           
  Lines        3349     3350    +1     
=======================================
+ Hits         2327     2328    +1     
  Misses       1022     1022           
Impacted Files Coverage Δ
src/core/utils.py 76.71% <ø> (ø)
src/sponsors/admin.py 100.00% <ø> (ø)
src/sponsors/api/views.py 41.17% <0.00%> (ø)
src/sponsors/models.py 91.83% <100.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ce0fbb...4f871a4. Read the comment docs.

Ritabear commented 2 years ago

@mattwang44 修改了~ 請幫我看看,感謝你!

Ritabear commented 2 years ago

@mattwang44 修改好了~~ 麻煩matt看一下