pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

feat(events/api): add GET SpeechListByCategory views, urls and tests #1085

Closed josix closed 2 years ago

josix commented 2 years ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Running GET {API_HOST}/api/events/speeches/category/WEB or others category like DATA, ML, etc.

Expected behavior

List all events which have the corresponding category and have the same schema as the original Speech List API.

Related Issue

1080

codecov-commenter commented 2 years ago

Codecov Report

Merging #1085 (7ad1297) into master (cb06278) will increase coverage by 0.35%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   69.14%   69.49%   +0.35%     
==========================================
  Files          82       82              
  Lines        3315     3340      +25     
==========================================
+ Hits         2292     2321      +29     
+ Misses       1023     1019       -4     
Impacted Files Coverage Δ
src/events/api/urls.py 100.00% <ø> (ø)
src/events/api/views.py 51.54% <100.00%> (+7.16%) :arrow_up:
src/core/models.py 96.20% <0.00%> (+5.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb06278...7ad1297. Read the comment docs.