search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

feat(settings.production.base): set GS_DEFAULT_ACL to publicRead #1108

Closed josix closed 1 year ago

josix commented 1 year ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Steps to Produce this PR

  1. put your google-cloud-storage.json under src/
  2. (Workaround) Rewrite https://github.com/pycontw/pycon.tw/blob/master/src/sponsors/models.py#L14 to return default_storage if False else GoogleCloudStorage()
  3. Copy L138 to L142 in https://github.com/pycontw/pycon.tw/pull/1108/files#diff-2ceb691b10b9d00dad55f62e98e5bf2916af93f9138538355a20604d2650ea8dR138-R142 to pycontw2016.base.py
  4. Run docker-compose -f ./docker-compose-dev.yml up

Description

Describe what the change is You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly self-describe enough about how you change the code.

Setting GS_DEFAULT_ACL to publicRead so that the return image URL would exclude the expiration period.

Expected behavior

The retrieved image url would not contain the expiration period.

Related Issue

closes #1107

More Information

Screenshots

image
mattwang44 commented 1 year ago

有先測過這個真的有用嗎XD？

josix commented 1 year ago

有喔我剛剛附錯圖了，如附圖

有先測過這個真的有用嗎XD？

baby230211 commented 1 year ago

logoUrl 後面的 expired time 沒了 LGTM