search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

Refactoring model options from models.py (issue#1119) #1122

Closed Ritabear closed 1 year ago

Ritabear commented 1 year ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly self-describe enough about how you change the code.

  1. rename migrations(del willing_to)
  2. rename some columns, having the string "willing_to"
  3. add choices.py
  4. move the string from core/models.py to core/choices.py ( the string = CATEGORY_CHOICES)
  5. For i18n, I make the commend makemessages.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen. Refacting the file.

Related Issue

If applicable, refernce to the issue related to this pull request.

1119

More Information

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. You may also want to refer to how to wirte the perfect pull request