search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

chore: rm CI requirements #1130

Closed mattwang44 closed 1 year ago

mattwang44 commented 1 year ago

Types of changes

Description

The CI requirements file is almost the same as the dev requirements file. Let CI also install from the latter and the former one can be deleted safely.

josix commented 1 year ago

我記得 ci.txt 是 @iknowright 上次加進來的，再麻煩後續幫忙 review，感謝🙇🏻‍♂️

mattwang44 commented 1 year ago

I know, that's why it's still a draft XD

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23 :tada:

Comparison is base (b99a224) 69.49% compared to head (baa45ba) 69.72%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1130 +/- ## ========================================== + Coverage 69.49% 69.72% +0.23% ========================================== Files 82 84 +2 Lines 3357 3376 +19 ========================================== + Hits 2333 2354 +21 + Misses 1024 1022 -2 ``` | [Impacted Files](https://codecov.io/gh/pycontw/pycon.tw/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw) | Coverage Δ | | |---|---|---| | [src/pycontw2016/urls.py](https://codecov.io/gh/pycontw/pycon.tw/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL3B5Y29udHcyMDE2L3VybHMucHk=) | `85.71% <ø> (ø)` | | | [src/proposals/api/urls.py](https://codecov.io/gh/pycontw/pycon.tw/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL3Byb3Bvc2Fscy9hcGkvdXJscy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/proposals/api/views.py](https://codecov.io/gh/pycontw/pycon.tw/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL3Byb3Bvc2Fscy9hcGkvdmlld3MucHk=) | `100.00% <100.00%> (ø)` | | | [src/reviews/models.py](https://codecov.io/gh/pycontw/pycon.tw/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL3Jldmlld3MvbW9kZWxzLnB5) | `86.66% <0.00%> (+2.66%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.