pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

chore(sponsor): remove sponsor-related deprecated code #1133

Closed mattwang44 closed 3 months ago

mattwang44 commented 1 year ago

Types of changes

Description

remove deprecated sponsor-related code

Note that I only modified/deleted those templates and static from 2023 code.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.99%. Comparing base (134b60e) to head (0303af9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## rm-schedule-model-and-views #1133 +/- ## =============================================================== + Coverage 73.16% 73.99% +0.83% =============================================================== Files 83 81 -2 Lines 3115 3057 -58 =============================================================== - Hits 2279 2262 -17 + Misses 836 795 -41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattwang44 commented 1 year ago

@Ritabear please review the unit tests of sponsor API

mattwang44 commented 1 year ago

@SivanYeh @erik1110 please join as the reviewer for the unit test part, thanks!

mattwang44 commented 1 year ago

@erik1110 @SivanYeh any progress here?

erik1110 commented 1 year ago

@erik1110 @SivanYeh any progress here? "I have set up the environment and am currently researching how to write test examples. I have left some questions in the discussion thread."

SivanYeh commented 1 year ago

@erik1110 @SivanYeh any progress here? @mattwang44 Same as Erik. Yet Josix may assign it to other member because of the approaching due. I would continue reading codes and asking.

mattwang44 commented 9 months ago

will rebase again after #1132 is merged

mattwang44 commented 3 months ago

Please let me know if this refactoring PR is either unwanted or still wanted. I wouldn't take any further action for now as it has been forgotten for quite a long time....

SivanYeh commented 3 months ago

@mattwang44 LGTM. I will resolve the conflix and create a new PR on src/templates/pycontw-2024 with similar redundancy

mattwang44 commented 3 months ago

rebased